Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] fix RSVP memory leak #14986

Merged
merged 1 commit into from
Mar 7, 2017
Merged

[BUGFIX release] fix RSVP memory leak #14986

merged 1 commit into from
Mar 7, 2017

Conversation

stefanpenner
Copy link
Member

This fixes two leaks:

  • the last error getting then created (mega rare)
  • the last rejection reason (more common, and lead to retaining the whole container once in ember-data’s tests)

@stefanpenner
[BUGFIX release] fix RSVP memory leak
bbd73e9 
This fixes two leaks:

* the last error getting `then` created (mega rare)
* the last rejection reason (more common, and lead to retaining the whole container once in ember-data’s tests)
@rwjblue rwjblue merged commit 9d6b72f into master Mar 7, 2017
@rwjblue rwjblue deleted the mem-leak branch March 7, 2017 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @rwjblue